← Back to team overview

launchpad-reviewers team mailing list archive

Re: [Merge] lp:~blr/launchpad/project-configuration-rename into lp:launchpad

 

> The changes to xx-productseries-translations.txt and xx-product-
> translations.txt look wrong. Those links aren't in a config section, so they
> should probably be "Configure Translations" rather than just "Translations".
> You also have "Configure code" rather than "Configure Code".
> 
Ah yes, I had forgotten there was a reason I didn't directly edit the link text in the previous branch - that menu also defines the links for the Answers/Translations/Bugs views etc. I'll revert that and fix those tests, thanks.

> What's the purpose of the VCS change in xx-create-codeimport.txt?
A bad cherry-pick of deprecated code (was used in the other branch for the git/bzr radiobuttons, but no longer needed there now).
-- 
https://code.launchpad.net/~blr/launchpad/project-configuration-rename/+merge/261918
Your team Launchpad code reviewers is subscribed to branch lp:launchpad.


References