launchpad-reviewers team mailing list archive

[Colin Watson <cjwatson@xxxxxxxxxxxxx>]

Colin Watson has proposed merging lp:~cjwatson/launchpad/update-deps-disjunctions into lp:launchpad.

Commit message:
Handle disjunctions in BinaryPackageBuild.updateDependencies.

Requested reviews:
  Launchpad code reviewers (launchpad-reviewers)

For more details, see:
https://code.launchpad.net/~cjwatson/launchpad/update-deps-disjunctions/+merge/263785

BinaryPackageBuild.updateDependencies correctly handles conjunctions in dep-waits (e.g. "foo, bar") but not disjunctions (e.g. "foo | bar").  This makes it awkward to improve the buildd side of the dep-wait code, because some dependency waits can only correctly be expressed using disjunctions.  Fortunately it's quite straightforward to fix this.
-- 
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~cjwatson/launchpad/update-deps-disjunctions into lp:launchpad.