launchpad-reviewers team mailing list archive

[William Grant <me@xxxxxxxxxxxxxxxxxx>]

Review: Approve code



Diff comments:

> === modified file 'lib/lp/registry/browser/productseries.py'
> === modified file 'lib/lp/registry/browser/tests/test_productseries_views.py'
> --- lib/lp/registry/browser/productseries.py	2015-07-06 00:00:55 +0000
> +++ lib/lp/registry/browser/productseries.py	2015-07-07 04:28:52 +0000
> @@ -386,8 +386,7 @@
>          """Meta string for golang remote import path.
>          See: https://golang.org/cmd/go/#hdr-Remote_import_paths
>          """
> -        if (self.context.product.vcs == VCSType.BZR and
> -            self.context.product.development_focus.branch):

You can drop the parens now.

> +        if (self.context.product.vcs == VCSType.BZR and self.context.branch):
>              return (
>                  "{hostname}/{product}/{series} bzr {root_url}{branch}").format(
>                      hostname=config.vhost.mainsite.hostname,


-- 
https://code.launchpad.net/~blr/launchpad/golang-meta-import-buggy-productseries/+merge/263994
Your team Launchpad code reviewers is subscribed to branch lp:launchpad.