launchpad-reviewers team mailing list archive

[Bayard 'kit' Randel <kit.randel@xxxxxxxxxxxxx>]

While I believe this does resolve the issue (the blankline before the dirty header is discarded by bzrlib.patches.parse), it does make the assumption that our diffs will continue to be rendered consistently in the form:

=== dirty header
--- patch header
+++ patch header
@ hunk header @
text
text
text

=== dirty header
etc.

I tested this branch against a very large real-world diff (elmo's) and it appeared to be behaving.

Colin, you suggested an approach which may work better for differing cases (git?), however I didn't entirely understand and would need to discuss it with you further. Shall we land this in the meantime to get things functional and look at refactoring? I can't say I love this code.
-- 
https://code.launchpad.net/~blr/launchpad/bug-1472045-demangle-inlinecomment-mail/+merge/264105
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~blr/launchpad/bug-1472045-demangle-inlinecomment-mail into lp:launchpad.