launchpad-reviewers team mailing list archive

[Colin Watson <cjwatson@xxxxxxxxxxxxx>]

Colin Watson has proposed merging lp:~cjwatson/launchpad/testfix-person-index-view into lp:launchpad.

Commit message:
Revert an unnecessary and incorrect classImplements transformation that broke Person:+index.

Requested reviews:
  Colin Watson (cjwatson)

For more details, see:
https://code.launchpad.net/~cjwatson/launchpad/testfix-person-index-view/+merge/264260

Revert an unnecessary and incorrect classImplements transformation that broke Person:+index.
-- 
Your team Launchpad code reviewers is subscribed to branch lp:launchpad.

=== modified file 'lib/lp/registry/browser/person.py'
--- lib/lp/registry/browser/person.py	2015-07-08 16:05:11 +0000
+++ lib/lp/registry/browser/person.py	2015-07-09 10:50:37 +0000
@@ -89,6 +89,7 @@
     TextWidget,
     )
 from zope.interface import (
+    classImplements,
     implementer,
     Interface,
     )
@@ -4386,7 +4387,6 @@
     """A marker interface for the +index navigation menu."""
 
 
-@implementer(IPersonIndexMenu)
 class PersonIndexMenu(NavigationMenu, PersonMenuMixin):
     usedfor = IPersonIndexMenu
     facet = 'overview'
@@ -4394,6 +4394,9 @@
     links = ('edit', 'administer', 'administer_account', 'branding')
 
 
+classImplements(PersonIndexView, IPersonIndexMenu)
+
+
 @implementer(Interface)
 class PersonXHTMLRepresentation:
     adapts(IPerson, IWebServiceClientRequest)