launchpad-reviewers team mailing list archive

[William Grant <me@xxxxxxxxxxxxxxxxxx>]

William Grant has proposed merging lp:~wgrant/launchpad/bzr-smart-whitelist into lp:launchpad.

Commit message:
Whitelist ConnectionTimeout and GhostRevisionsHaveNoRevno bzr smartserver exceptions. They're client errors.

Requested reviews:
  Launchpad code reviewers (launchpad-reviewers)

For more details, see:
https://code.launchpad.net/~wgrant/launchpad/bzr-smart-whitelist/+merge/264378

Whitelist ConnectionTimeout and GhostRevisionsHaveNoRevno bzr smartserver exceptions. They're client errors, and the OOPS report pollution is quite tiresome.
-- 
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~wgrant/launchpad/bzr-smart-whitelist into lp:launchpad.

=== modified file 'lib/lp/codehosting/bzrutils.py'
--- lib/lp/codehosting/bzrutils.py	2015-07-06 14:12:12 +0000
+++ lib/lp/codehosting/bzrutils.py	2015-07-10 06:12:00 +0000
@@ -34,6 +34,8 @@
     )
 from bzrlib.errors import (
     AppendRevisionsOnlyViolation,
+    ConnectionTimeout,
+    GhostRevisionsHaveNoRevno,
     NotStacked,
     UnstackableBranchFormat,
     UnstackableRepositoryFormat,
@@ -58,7 +60,10 @@
     )
 
 # Exception classes which are not converted into OOPSes
-NOT_OOPS_EXCEPTIONS = (AppendRevisionsOnlyViolation,)
+NOT_OOPS_EXCEPTIONS = (
+    AppendRevisionsOnlyViolation, ConnectionTimeout,
+    GhostRevisionsHaveNoRevno)
+
 
 def should_log_oops(exc):
     """Return true if exc should trigger an OOPS.