launchpad-reviewers team mailing list archive

[Riccardo Padovani <riccardo@xxxxxxxxxxxxx>]

Riccardo Padovani has proposed merging lp:~rpadovani/launchpad/link-revision-merged-mp into lp:launchpad.

Commit message:
Link to revision for merged MPs 

Add link to the revision in the summary of merge proposal page
Fix #892259 

Requested reviews:
  Launchpad code reviewers (launchpad-reviewers)
Related bugs:
  Bug #892259 in Launchpad itself: "Link to revision for merged MPs"
  https://bugs.launchpad.net/launchpad/+bug/892259

For more details, see:
https://code.launchpad.net/~rpadovani/launchpad/link-revision-merged-mp/+merge/264654

Summary
Fix bug #892259

"Merged into lp:pkgme at revision 86". "Merged" is a link; "lp:pkgme" is a link, but "revision 86" is not.

Proposed fix
Add link to the revision

Pre-implementation notes
My first patch to lp itself :-)

Implementation details
I just changed the template of the merge proposal summary page.

Tests
I didn't write any. Should I?

Demo and Q/A
Just run it locally and go on a summary of a branch merged in another branch
-- 
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~rpadovani/launchpad/link-revision-merged-mp into lp:launchpad.

=== modified file 'lib/lp/code/templates/branchmergeproposal-link-summary.pt'
--- lib/lp/code/templates/branchmergeproposal-link-summary.pt	2015-06-10 10:25:28 +0000
+++ lib/lp/code/templates/branchmergeproposal-link-summary.pt	2015-07-13 22:27:22 +0000
@@ -18,7 +18,10 @@
   </tal:source-branch>
   <tal:for-merging condition="context/queue_status/enumvalue:MERGED">
     <tal:have-revision condition="context/merged_revision">
-      at revision <tal:revision replace="context/merged_revision"/>
+      at
+      <a tal:attributes="href context/merged_revision">
+        revision <tal:revision replace="context/merged_revision"/>
+      </a>
     </tal:have-revision>
   </tal:for-merging>
 </tal:root>