launchpad-reviewers team mailing list archive

[Colin Watson <cjwatson@xxxxxxxxxxxxx>]

Colin Watson has proposed merging lp:~cjwatson/launchpad/db-snappy into lp:launchpad/db-devel.

Commit message:
Add Snap, SnapBuild, and SnapFile tables.

Requested reviews:
  Launchpad code reviewers (launchpad-reviewers)
Related bugs:
  Bug #1476405 in Launchpad itself: "Add support for building snaps"
  https://bugs.launchpad.net/launchpad/+bug/1476405

For more details, see:
https://code.launchpad.net/~cjwatson/launchpad/db-snappy/+merge/265332

Add Snap, SnapBuild, and SnapFile tables.

This is basically LiveFS with the serial numbers filed off, although instead of having a metadata dict we take a Branch/GitRef and expect that to contain the snapcraft recipe.  I initially went for a recipe text column containing YAML, but following discussion with the snapcraft team a version control branch seems to be the most sensible way to pass the recipe, not least because there may need to be some other snap-specific metadata other than snapcraft.yaml and so one will often want a container for that anyway.
-- 
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~cjwatson/launchpad/db-snappy into lp:launchpad/db-devel.

=== added file 'database/schema/patch-2209-69-0.sql'
--- database/schema/patch-2209-69-0.sql	1970-01-01 00:00:00 +0000
+++ database/schema/patch-2209-69-0.sql	2015-07-20 21:47:20 +0000
@@ -0,0 +1,128 @@
+-- Copyright 2015 Canonical Ltd.  This software is licensed under the
+-- GNU Affero General Public License version 3 (see the file LICENSE).
+
+SET client_min_messages=ERROR;
+
+CREATE TABLE Snap (
+    id serial PRIMARY KEY,
+    date_created timestamp without time zone DEFAULT (CURRENT_TIMESTAMP AT TIME ZONE 'UTC') NOT NULL,
+    date_last_modified timestamp without time zone DEFAULT (CURRENT_TIMESTAMP AT TIME ZONE 'UTC') NOT NULL,
+    registrant integer NOT NULL REFERENCES person,
+    owner integer NOT NULL REFERENCES person,
+    distro_series integer NOT NULL REFERENCES distroseries,
+    name text NOT NULL,
+    branch integer REFERENCES branch,
+    git_repository integer REFERENCES gitrepository,
+    git_path text,
+    require_virtualized boolean DEFAULT true NOT NULL,
+    CONSTRAINT valid_name CHECK (valid_name(name)),
+    CONSTRAINT consistent_git_ref CHECK ((git_repository IS NULL) = (git_path IS NULL)),
+    CONSTRAINT one_vcs CHECK ((branch IS NULL) != (git_repository IS NULL)),
+    CONSTRAINT snap__owner__name__key UNIQUE (owner, name)
+);
+
+COMMENT ON TABLE Snap IS 'A snap package.';
+COMMENT ON COLUMN Snap.registrant IS 'The user who registered the snap package.';
+COMMENT ON COLUMN Snap.owner IS 'The owner of the snap package.';
+COMMENT ON COLUMN Snap.distro_series IS 'The DistroSeries for which the snap package should be built.';
+COMMENT ON COLUMN Snap.name IS 'The name of the snap package, unique per owner and DistroSeries.';
+COMMENT ON COLUMN Snap.branch IS 'A Bazaar branch containing a snap recipe.';
+COMMENT ON COLUMN Snap.git_repository IS 'A Git repository with a branch containing a snap recipe.';
+COMMENT ON COLUMN Snap.git_path IS 'The path of the Git branch containing a snap recipe.';
+COMMENT ON COLUMN Snap.require_virtualized IS 'If True, this snap package must be built only on a virtual machine.';
+
+CREATE INDEX snap__registrant__idx
+    ON Snap (registrant);
+CREATE INDEX snap__owner__idx
+    ON Snap (owner);
+CREATE INDEX snap__distro_series__idx
+    ON Snap (distro_series);
+CREATE INDEX snap__name__idx
+    ON Snap (name);
+
+CREATE TABLE SnapBuild (
+    id serial PRIMARY KEY,
+    requester integer NOT NULL REFERENCES person,
+    snap integer NOT NULL REFERENCES snap,
+    archive integer NOT NULL REFERENCES archive,
+    distro_arch_series integer NOT NULL REFERENCES distroarchseries,
+    pocket integer NOT NULL,
+    processor integer NOT NULL REFERENCES processor,
+    virtualized boolean NOT NULL,
+    date_created timestamp without time zone DEFAULT (CURRENT_TIMESTAMP AT TIME ZONE 'UTC') NOT NULL,
+    date_started timestamp without time zone,
+    date_finished timestamp without time zone,
+    date_first_dispatched timestamp without time zone,
+    builder integer REFERENCES builder,
+    status integer NOT NULL,
+    log integer REFERENCES libraryfilealias,
+    upload_log integer REFERENCES libraryfilealias,
+    dependencies text,
+    failure_count integer DEFAULT 0 NOT NULL,
+    build_farm_job integer NOT NULL REFERENCES buildfarmjob
+);
+
+COMMENT ON TABLE SnapBuild IS 'A build record for a snap package.';
+COMMENT ON COLUMN SnapBuild.requester IS 'The person who requested this snap package build.';
+COMMENT ON COLUMN SnapBuild.snap IS 'The snap package to build.';
+COMMENT ON COLUMN SnapBuild.archive IS 'The archive that the snap package should build from.';
+COMMENT ON COLUMN SnapBuild.distro_arch_series IS 'The distroarchseries that the snap package should build from.';
+COMMENT ON COLUMN SnapBuild.pocket IS 'The pocket that the snap package should build from.';
+COMMENT ON COLUMN SnapBuild.virtualized IS 'The virtualization setting required by this build farm job.';
+COMMENT ON COLUMN SnapBuild.date_created IS 'When the build farm job record was created.';
+COMMENT ON COLUMN SnapBuild.date_started IS 'When the build farm job started being processed.';
+COMMENT ON COLUMN SnapBuild.date_finished IS 'When the build farm job finished being processed.';
+COMMENT ON COLUMN SnapBuild.date_first_dispatched IS 'The instant the build was dispatched the first time.  This value will not get overridden if the build is retried.';
+COMMENT ON COLUMN SnapBuild.builder IS 'The builder which processed this build farm job.';
+COMMENT ON COLUMN SnapBuild.status IS 'The current build status.';
+COMMENT ON COLUMN SnapBuild.log IS 'The log file for this build farm job stored in the librarian.';
+COMMENT ON COLUMN SnapBuild.upload_log IS 'The upload log file for this build farm job stored in the librarian.';
+COMMENT ON COLUMN SnapBuild.dependencies IS 'A Debian-like dependency line specifying the current missing dependencies for this build.';
+COMMENT ON COLUMN SnapBuild.failure_count IS 'The number of consecutive failures on this job.  If excessive, the job may be terminated.';
+COMMENT ON COLUMN SnapBuild.build_farm_job IS 'The build farm job with the base information.';
+
+CREATE INDEX snapbuild__requester__idx
+    ON SnapBuild (requester);
+CREATE INDEX snapbuild__snap__idx
+    ON SnapBuild (snap);
+CREATE INDEX snapbuild__archive__idx
+    ON SnapBuild (archive);
+CREATE INDEX snapbuild__distro_arch_series__idx
+    ON SnapBuild (distro_arch_series);
+CREATE INDEX snapbuild__log__idx
+    ON SnapBuild (log);
+CREATE INDEX snapbuild__upload_log__idx
+    ON SnapBuild (upload_log);
+CREATE INDEX snapbuild__build_farm_job__idx
+    ON SnapBuild (build_farm_job);
+
+-- Snap.requestBuild
+CREATE INDEX snapbuild__snap__archive__das__pocket__status__idx
+    ON SnapBuild (snap, archive, distro_arch_series, pocket, status);
+
+-- Snap.builds, Snap.completed_builds, Snap.pending_builds
+CREATE INDEX snapbuild__snap__status__started__finished__created__id__idx
+    ON SnapBuild (
+        snap, status, GREATEST(date_started, date_finished) DESC NULLS LAST,
+        date_created DESC, id DESC);
+
+-- SnapBuild.getMedianBuildDuration
+CREATE INDEX snapbuild__snap__das__status__finished__idx
+    ON SnapBuild (snap, distro_arch_series, status, date_finished DESC)
+    -- 1 == FULLYBUILT
+    WHERE status = 1;
+
+CREATE TABLE SnapFile (
+    id serial PRIMARY KEY,
+    snapbuild integer NOT NULL REFERENCES snapbuild,
+    libraryfile integer NOT NULL REFERENCES libraryfilealias
+);
+
+COMMENT ON TABLE SnapFile IS 'A link between a snap package build and a file in the librarian that it produces.';
+COMMENT ON COLUMN SnapFile.snapbuild IS 'The snap package build producing this file.';
+COMMENT ON COLUMN SnapFile.libraryfile IS 'A file in the librarian.';
+
+CREATE INDEX snapfile__snapbuild__idx
+    ON SnapFile (snapbuild);
+
+INSERT INTO LaunchpadDatabaseRevision VALUES (2209, 69, 0);

=== modified file 'database/schema/security.cfg'
--- database/schema/security.cfg	2015-07-15 06:20:47 +0000
+++ database/schema/security.cfg	2015-07-20 21:47:20 +0000
@@ -289,6 +289,9 @@
 public.scriptactivity                   = SELECT
 public.seriessourcepackagebranch        = SELECT, INSERT, UPDATE, DELETE
 public.sharingjob                       = SELECT, INSERT, UPDATE, DELETE
+public.snap                             = SELECT, INSERT, UPDATE, DELETE
+public.snapbuild                        = SELECT, INSERT, UPDATE, DELETE
+public.snapfile                         = SELECT, INSERT, UPDATE, DELETE
 public.sourcepackageformatselection     = SELECT
 public.sourcepackagepublishinghistory   = SELECT
 public.sourcepackagerecipe              = SELECT, INSERT, UPDATE, DELETE
@@ -442,6 +445,8 @@
 public.product                          = SELECT
 public.productreleasefile               = SELECT
 public.project                          = SELECT
+public.snapbuild                        = SELECT
+public.snapfile                         = SELECT
 public.sourcepackagerecipebuild         = SELECT
 public.sourcepackagerelease             = SELECT
 public.sourcepackagereleasefile         = SELECT
@@ -978,6 +983,9 @@
 public.publisherconfig                        = SELECT
 public.section                                = SELECT
 public.seriessourcepackagebranch              = SELECT
+public.snap                                   = SELECT
+public.snapbuild                              = SELECT, UPDATE
+public.snapfile                               = SELECT
 public.sourcepackagename                      = SELECT
 public.sourcepackagepublishinghistory         = SELECT
 public.sourcepackagerecipe                    = SELECT
@@ -1399,6 +1407,9 @@
 public.sectionselection                 = SELECT
 public.sharingjob                       = SELECT, INSERT, UPDATE
 public.signedcodeofconduct              = SELECT
+public.snap                             = SELECT, UPDATE
+public.snapbuild                        = SELECT, UPDATE
+public.snapfile                         = SELECT, INSERT, UPDATE
 public.sourcepackagefilepublishing      = SELECT
 public.sourcepackageformatselection     = SELECT
 public.sourcepackagename                = SELECT, INSERT
@@ -1508,6 +1519,8 @@
 public.section                          = SELECT
 public.sectionselection                 = SELECT
 public.sharingjob                       = SELECT, INSERT, UPDATE
+public.snapbuild                        = SELECT
+public.snapfile                         = SELECT, UPDATE
 public.sourcepackagefilepublishing      = SELECT
 public.sourcepackagename                = SELECT
 public.sourcepackagepublishinghistory   = SELECT, INSERT, UPDATE
@@ -2205,6 +2218,8 @@
 public.seriessourcepackagebranch        = SELECT, UPDATE
 public.sharingjob                       = SELECT, INSERT, UPDATE
 public.signedcodeofconduct              = SELECT, UPDATE
+public.snap                             = SELECT, UPDATE
+public.snapbuild                        = SELECT, UPDATE
 public.sourcepackagename                = SELECT
 public.sourcepackagepublishinghistory   = SELECT, UPDATE
 public.sourcepackagerecipe              = SELECT, UPDATE
@@ -2289,6 +2304,7 @@
 public.previewdiff                      = SELECT, DELETE
 public.revisionauthor                   = SELECT, UPDATE
 public.revisioncache                    = SELECT, DELETE
+public.snapfile                         = SELECT, DELETE
 public.sourcepackagename                = SELECT
 public.sourcepackagerelease             = SELECT
 public.sourcepackagepublishinghistory   = SELECT, UPDATE