launchpad-reviewers team mailing list archive

[William Grant <me@xxxxxxxxxxxxxxxxxx>]

Review: Approve code



Diff comments:

> 
> === modified file 'lib/lp/registry/interfaces/person.py'
> --- lib/lp/registry/interfaces/person.py	2015-05-11 13:17:41 +0000
> +++ lib/lp/registry/interfaces/person.py	2015-07-14 14:44:02 +0000
> @@ -552,6 +552,14 @@
>          title=_("Send me bug notifications for changes I make"),
>          required=False, default=False)
>  
> +    expanded_notification_footers = Bool(
> +        title=_("Include filtering information in e-mail footers"),
> +        description=_(
> +            "Some e-mail clients do not allow filtering on arbitrary message "
> +            "headers.  If you use one of these, you can set this option to "
> +            "add more information to the end of message bodies."),
> +        required=False, default=False)

I'd prefer that we exterminated the spelling "e-mail" from the codebase.

> +
>  
>  class IPersonPublic(IPrivacy):
>      """Public attributes for a Person.


-- 
https://code.launchpad.net/~cjwatson/launchpad/mail-footer-pref/+merge/264720
Your team Launchpad code reviewers is subscribed to branch lp:launchpad.