launchpad-reviewers team mailing list archive

[Riccardo Padovani <riccardo@xxxxxxxxxxxxx>]

The proposal to merge lp:~rpadovani/launchpad/link-revision-merged-mp into lp:launchpad has been updated.

Description changed to:

Summary
Fix bug #892259

"Merged into lp:pkgme at revision 86". "Merged" is a link; "lp:pkgme" is a link, but "revision 86" is not.

Proposed fix
Add link to the revision

Pre-implementation notes
My first patch to lp itself :-)

Implementation details
Create a new method in IGitRepository and IBranchRepository to create url to a commit/revision in the branch.
Use it to create the property for the template

Tests
1 test to check the html and 2 tests to check the new method

Demo and Q/A
Just run it locally and go on a summary of a branch merged in another branch

For more details, see:
https://code.launchpad.net/~rpadovani/launchpad/link-revision-merged-mp/+merge/264654
-- 
Your team Launchpad code reviewers is subscribed to branch lp:launchpad.