launchpad-reviewers team mailing list archive

[Colin Watson <cjwatson@xxxxxxxxxxxxx>]

Colin Watson has proposed merging lp:~cjwatson/launchpad/db-livefs-build-ordering into lp:launchpad/db-devel.

Commit message:
Add NULLS LAST to LiveFS.*builds index.

Requested reviews:
  Launchpad code reviewers (launchpad-reviewers)
Related bugs:
  Bug #1424672 in Launchpad itself: "LiveFS builds cancelled before they start sort above other builds in history"
  https://bugs.launchpad.net/launchpad/+bug/1424672

For more details, see:
https://code.launchpad.net/~cjwatson/launchpad/db-livefs-build-ordering/+merge/265660

Add NULLS LAST to LiveFS.*builds index, following https://code.launchpad.net/~cjwatson/launchpad/livefs-build-ordering/+merge/265320.
-- 
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~cjwatson/launchpad/db-livefs-build-ordering into lp:launchpad/db-devel.

=== added file 'database/schema/patch-2209-56-1.sql'
--- database/schema/patch-2209-56-1.sql	1970-01-01 00:00:00 +0000
+++ database/schema/patch-2209-56-1.sql	2015-07-23 13:24:27 +0000
@@ -0,0 +1,13 @@
+-- Copyright 2015 Canonical Ltd.  This software is licensed under the
+-- GNU Affero General Public License version 3 (see the file LICENSE).
+
+SET client_min_messages=ERROR;
+
+DROP INDEX livefsbuild__livefs__status__started__finished__created__id__idx;
+
+CREATE INDEX livefsbuild__livefs__status__started__finished__created__id__idx
+    ON LiveFSBuild (
+        livefs, status, GREATEST(date_started, date_finished) DESC NULLS LAST,
+        date_created DESC, id DESC);
+
+INSERT INTO LaunchpadDatabaseRevision VALUES (2209, 56, 1);