launchpad-reviewers team mailing list archive

[Colin Watson <cjwatson@xxxxxxxxxxxxx>]

Review: Needs Fixing

This needs to use config.launchpad.openid_provider_root rather than hardcoding https://login.launchpad.net/; we run multiple Launchpad instances and staging uses a different provider.

There should be a test that this link exists and goes somewhere suitable.  A lot of registry tests are spread around in doctests for historical reasons, but for a new test I'd suggest putting it in TestPersonIndexView.  It could just fetch an appropriate Person:+index and use BeautifulSoup/soupmatchers/etc. to check for the link; there are various examples of doing that kind of thing in the file containing TestPersonIndexView.
-- 
https://code.launchpad.net/~bryanquigley/launchpad/devel/+merge/266247
Your team Launchpad code reviewers is subscribed to branch lp:launchpad.