launchpad-reviewers team mailing list archive

[Colin Watson <cjwatson@xxxxxxxxxxxxx>]

Colin Watson has proposed merging lp:~cjwatson/launchpad/prf-size-1gib into lp:launchpad.

Commit message:
Bump max_productrelease_file_size to 1GiB.

Requested reviews:
  Launchpad code reviewers (launchpad-reviewers)
Related bugs:
  Bug #1479441 in Launchpad itself: "Increase single file upload limit"
  https://bugs.launchpad.net/launchpad/+bug/1479441

For more details, see:
https://code.launchpad.net/~cjwatson/launchpad/prf-size-1gib/+merge/266688

Bump max_productrelease_file_size to 1GiB.  Hopefully this won't result in upload timeouts.
-- 
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~cjwatson/launchpad/prf-size-1gib into lp:launchpad.

=== modified file 'lib/lp/registry/stories/product/xx-product-files.txt'
--- lib/lp/registry/stories/product/xx-product-files.txt	2014-11-27 07:48:25 +0000
+++ lib/lp/registry/stories/product/xx-product-files.txt	2015-08-03 08:21:42 +0000
@@ -220,7 +220,7 @@
     >>> content = find_main_content(firefox_owner.contents)
     >>> print content
     <...
-    ...You may upload files up to 200.0 MiB...
+    ...You may upload files up to 1.0 GiB...
 
 Create a file to upload, and upload it. We'll also upload a dummy signature.
 Uploading file signatures is optional, so we'll just try it this once.

=== modified file 'lib/lp/services/config/schema-lazr.conf'
--- lib/lp/services/config/schema-lazr.conf	2015-07-02 07:09:25 +0000
+++ lib/lp/services/config/schema-lazr.conf	2015-08-03 08:21:42 +0000
@@ -879,8 +879,8 @@
 # Maximum size of product release download files in bytes. A value
 # of 0 means no limit.
 # datatype: integer
-# 200MiB
-max_productrelease_file_size: 209715200
+# 1GiB
+max_productrelease_file_size: 1073741824
 
 # Maximum size of a product release download file signature in bytes.
 # A value of 0 means no limit.