launchpad-reviewers team mailing list archive
-
launchpad-reviewers team
-
Mailing list archive
-
Message #19179
Re: [Merge] lp:~wgrant/launchpad/webhook-browser into lp:launchpad
Review: Approve
Diff comments:
> === modified file 'lib/lp/app/browser/launchpad.py'
> --- lib/lp/app/browser/launchpad.py 2015-07-23 16:41:12 +0000
> +++ lib/lp/app/browser/launchpad.py 2015-08-04 14:01:31 +0000
> @@ -356,14 +354,14 @@
> else:
> return None
>
> - def makeBreadcrumbForRequestedPage(self):
> - """Return an `IBreadcrumb` for the requested page.
> + def makeBreadcrumbsForRequestedPage(self):
> + """Return a sequence of `IBreadcrumb`s for the requested page.
>
> The `IBreadcrumb` for the requested page is created using the current
> URL and the page's name (i.e. the last path segment of the URL).
>
> If the view is the default one for the object or the current
> - facet, return None -- we'll have injected a facet Breadcrumb
> + facet, return none -- we'll have injected a facet Breadcrumb
Return [] rather than None or none, presumably?
> earlier in the hierarchy which links here.
> """
> url = self.request.getURL()
>
> === added directory 'lib/lp/services/webhooks/templates'
> === added file 'lib/lp/services/webhooks/templates/webhook-delete.pt'
> --- lib/lp/services/webhooks/templates/webhook-delete.pt 1970-01-01 00:00:00 +0000
> +++ lib/lp/services/webhooks/templates/webhook-delete.pt 2015-08-04 14:01:31 +0000
> @@ -0,0 +1,28 @@
> +<html
> + xmlns="http://www.w3.org/1999/xhtml";
> + xmlns:tal="http://xml.zope.org/namespaces/tal";
> + xmlns:metal="http://xml.zope.org/namespaces/metal";
> + xmlns:i18n="http://xml.zope.org/namespaces/i18n";
> + metal:use-macro="view/macro:page/main_only"
> + i18n:domain="launchpad">
> +<body>
> +
> + <div metal:fill-slot="main">
> + <div metal:use-macro="context/@@launchpad_form/form">
> + <div metal:fill-slot="extra_info">
> + <p>
> + Deleting this webhook will prevent future events from being
> + sent to
> + <tt tal:content="context/delivery_url">http://example.com/ep</tt>,
> + and any pending deliveries will be permanently lost.
Records of past deliveries too, I guess?
> + </p>
> + <p>
> + If you just want to temporarily suspend deliveries, deactivate
> + the webhook instead.
> + </p>
> + </div>
> + </div>
> + </div>
> +
> +</body>
> +</html>
--
https://code.launchpad.net/~wgrant/launchpad/webhook-browser/+merge/266870
Your team Launchpad code reviewers is subscribed to branch lp:launchpad.
References
