launchpad-reviewers team mailing list archive

[Bayard 'kit' Randel <kit.randel@xxxxxxxxxxxxx>]

Review: Approve

One trivial style issue.

Diff comments:

> 
> === modified file 'lib/lp/services/webhooks/tests/test_job.py'
> --- lib/lp/services/webhooks/tests/test_job.py	2015-08-04 13:37:56 +0000
> +++ lib/lp/services/webhooks/tests/test_job.py	2015-08-10 09:33:28 +0000
> @@ -313,7 +325,9 @@
>               {'Content-Type': 'application/json',
>                'User-Agent': 'launchpad.dev-Webhooks/r%s' % revno,
>                'X-Hub-Signature':
> -                'sha1=de75f136c37d89f5eb24834468c1ecd602fa95dd'}),
> +                'sha1=de75f136c37d89f5eb24834468c1ecd602fa95dd',

flake8 unhappy with this indent [E127].

> +              'X-Launchpad-Event-Type': 'test',
> +              'X-Launchpad-Delivery': str(job.job_id)}),
>              ], reqs)
>          self.assertEqual([], oopses.oopses)
>  


-- 
https://code.launchpad.net/~wgrant/launchpad/webhook-trigger/+merge/267488
Your team Launchpad code reviewers is subscribed to branch lp:launchpad.