launchpad-reviewers team mailing list archive

[Colin Watson <cjwatson@xxxxxxxxxxxxx>]

Review: Approve



Diff comments:

> === modified file 'lib/lp/services/webhooks/client.py'
> --- lib/lp/services/webhooks/client.py	2015-08-10 08:09:09 +0000
> +++ lib/lp/services/webhooks/client.py	2015-08-24 01:25:37 +0000
> @@ -18,6 +18,24 @@
>  from lp.services.webhooks.interfaces import IWebhookClient
>  
>  
> +SQUID_ERROR_MESSAGES = {
> +    "ERR_ACCESS_DENIED": "URL not allowed",
> +    "ERR_READ_TIMEOUT": "Connection read timeout",
> +    "ERR_LIFETIME_EXP": "Connection lifetime expired",
> +    "ERR_READ_ERROR": "Connection read error",
> +    "ERR_WRITE_ERROR": "Connection write error",
> +    "ERR_CONNECT_FAIL": "Connection failed",
> +    "ERR_SOCKET_FAILURE": "Connection failed",

Can these two have different descriptions, please?  ERR_SOCKET_FAILURE is an allocation failure, not a connection failure.  This is Squid's user-visible rendering of it:

  http://bazaar.launchpad.net/~squid/squid/3-trunk/view/head:/errors/templates/ERR_SOCKET_FAILURE

> +    "ERR_DNS_FAIL": "DNS lookup failed",
> +    "ERR_TOO_BIG": "HTTP request or reply too large",
> +    "ERR_INVALID_RESP": "HTTP response invalid",
> +    "ERR_INVALID_REQ": "HTTP request invalid",
> +    "ERR_UNSUP_REQ": "HTTP request unsupported",
> +    "ERR_INVALID_URL": "HTTP URL invalid",
> +    "ERR_ZERO_SIZE_OBJECT": "HTTP response empty",
> +    }
> +
> +
>  def create_request(user_agent, secret, delivery_id, event_type, payload):
>      body = json.dumps(payload)
>      headers = {


-- 
https://code.launchpad.net/~wgrant/launchpad/webhook-proxy-errors/+merge/268865
Your team Launchpad code reviewers is subscribed to branch lp:launchpad.