launchpad-reviewers team mailing list archive

[Colin Watson <cjwatson@xxxxxxxxxxxxx>]

Colin Watson has proposed merging lp:~cjwatson/launchpad/delete-dsp-component-ui into lp:launchpad.

Commit message:
Stop showing the confusing .dsc component on DistributionSourcePackage:+index.

Requested reviews:
  Launchpad code reviewers (launchpad-reviewers)
Related bugs:
  Bug #521722 in Launchpad itself: "Display of Component on distro source summary page may be wrong (but we know the right value)"
  https://bugs.launchpad.net/launchpad/+bug/521722

For more details, see:
https://code.launchpad.net/~cjwatson/launchpad/delete-dsp-component-ui/+merge/270169

Stop showing the confusing .dsc component on DistributionSourcePackage:+index.  It is almost never useful for anything, and its main practical effect is to confuse people into not noticing the per-series publication information which is what people generally actually want to know.
-- 
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~cjwatson/launchpad/delete-dsp-component-ui into lp:launchpad.

=== modified file 'lib/lp/registry/templates/distributionsourcepackage-index.pt'
--- lib/lp/registry/templates/distributionsourcepackage-index.pt	2013-05-01 17:09:37 +0000
+++ lib/lp/registry/templates/distributionsourcepackage-index.pt	2015-09-04 12:44:11 +0000
@@ -75,10 +75,6 @@
             <dt>Urgency:<sup>*</sup></dt>
             <dd tal:content="current/urgency/title"/>
           </dl>
-          <dl style="clear:both">
-            <dt>Component:<sup>*</sup></dt>
-            <dd tal:content="current/component/name"/>
-          </dl>
           <dl>
             <dt>Architectures:<sup>*</sup></dt>
             <dd tal:content="current/architecturehintlist"/>

=== modified file 'lib/lp/soyuz/stories/distribution/xx-distribution-packages.txt'
--- lib/lp/soyuz/stories/distribution/xx-distribution-packages.txt	2015-06-26 14:00:41 +0000
+++ lib/lp/soyuz/stories/distribution/xx-distribution-packages.txt	2015-09-04 12:44:11 +0000
@@ -264,7 +264,6 @@
     Package information
     Maintainer: Foo Bar
     Urgency:* Low Urgency
-    Component:* main
     Architectures:* any
     Latest upload: 1.0
     *actual publishing details may vary in this distribution, these are just