launchpad-reviewers team mailing list archive

[Colin Watson <cjwatson@xxxxxxxxxxxxx>]

Review: Approve



Diff comments:

> 
> === modified file 'lib/lp/code/model/sourcepackagerecipebuild.py'
> --- lib/lp/code/model/sourcepackagerecipebuild.py	2015-07-08 16:05:11 +0000
> +++ lib/lp/code/model/sourcepackagerecipebuild.py	2015-09-11 10:09:28 +0000
> @@ -177,10 +177,11 @@
>      @property
>      def title(self):
>          if self.recipe is None:
> -            return 'build for deleted recipe'
> +            branch_name = 'deleted'
>          else:
>              branch_name = self.recipe.base_branch.unique_name
> -            return '%s recipe build' % branch_name
> +        return '%s recipe build in %s %s' % (
> +            branch_name, self.distribution.name, self.distroseries.name)

You could just use '%s' % self.distroseries if you like, since DistroSeries.__str__ is the same as that.

>  
>      def __init__(self, build_farm_job, distroseries, recipe, requester,
>                   archive, pocket, date_created):


-- 
https://code.launchpad.net/~wgrant/launchpad/recipe-title-series/+merge/270792
Your team Launchpad code reviewers is subscribed to branch lp:launchpad.