launchpad-reviewers team mailing list archive

[Colin Watson <cjwatson@xxxxxxxxxxxxx>]

Hm.  Possibly, and fixing that is difficult with the current structure (CodeReviewComment.vote isn't in the UNIONed result set).  I'm thinking that the best way to tackle this might be to do something like what we did with Snap, and move the queries for merge proposals on collections to the BranchMergeProposal model so that we can use a simple OR here rather than a UNION.  We would have to think carefully about how to design the bits that remain on *Collection - there'd have to be some reasonable way to extract symmetric vs. asymmetric expressions - but we'd probably still end up with a net reduction of code as well as being able to support this case.  Does that sound reasonable?
-- 
https://code.launchpad.net/~cjwatson/launchpad/git-getRequestedReviews/+merge/271136
Your team Launchpad code reviewers is subscribed to branch lp:launchpad.