launchpad-reviewers team mailing list archive

[William Grant <me@xxxxxxxxxxxxxxxxxx>]

Review: Approve code

This will also affect partner, and I don't think we've checked its mirror scripts.

Diff comments:

> 
> === modified file 'lib/lp/archivepublisher/tests/archive-signing.txt'
> --- lib/lp/archivepublisher/tests/archive-signing.txt	2012-09-20 12:00:22 +0000
> +++ lib/lp/archivepublisher/tests/archive-signing.txt	2015-09-23 15:47:46 +0000
> @@ -415,6 +426,11 @@
>      >>> signature.fingerprint == expected_fingerprint
>      True
>  
> +    >>> inline_signature = gpghandler.getVerifiedSignature(
> +    ...     content=open(inline_release_path).read())
> +    >>> inline_signature.fingerprint == expected_fingerprint
> +    True

Can you also check that the verified content is correct?

> +
>  Finally, if we try to sign a repository for which the archive doesn't
>  have a 'signing_key' set,  it raises an error.
>  


-- 
https://code.launchpad.net/~cjwatson/launchpad/inline-release/+merge/272132
Your team Launchpad code reviewers is subscribed to branch lp:launchpad.