launchpad-reviewers team mailing list archive

[Colin Watson <cjwatson@xxxxxxxxxxxxx>]

Review: Approve



Diff comments:

> 
> === modified file 'lib/lp/bugs/tests/buglinktarget.txt'
> --- lib/lp/bugs/tests/buglinktarget.txt	2015-09-25 10:15:37 +0000
> +++ lib/lp/bugs/tests/buglinktarget.txt	2015-09-29 06:06:37 +0000
> @@ -87,13 +87,16 @@
>      >>> private_bug = bugset.get(6)
>      >>> private_bug.setPrivate(True, factory.makePerson())
>      True
> -    >>> target.linkBug(private_bug)
> +    >>> target.linkBug(private_bug, factory.makePerson())
>      Traceback (most recent call last):
>        ...
>      Unauthorized...
>  
> +    >>> from lp.registry.interfaces.person import IPersonSet
> +    >>> admin = getUtility(IPersonSet).getByEmail('admin@xxxxxxxxxxxxx')
>      >>> login('foo.bar@xxxxxxxxxxxxx')
> -    >>> private_link = target.linkBug(private_bug)
> +    >>> target.linkBug(private_bug, admin)
> +    True

Do you still need the login() here and below?

>  
>  == bugs ==
>  


-- 
https://code.launchpad.net/~wgrant/launchpad/buglinks-user/+merge/272689
Your team Launchpad code reviewers is subscribed to branch lp:launchpad.