launchpad-reviewers team mailing list archive

[Colin Watson <cjwatson@xxxxxxxxxxxxx>]

Colin Watson has proposed merging lp:~cjwatson/launchpad/upload-timestamp-cutoff-1975 into lp:launchpad.

Commit message:
Bump future_time_grace to 24 hours and earliest_year to 1975, to match Debian.

Requested reviews:
  Launchpad code reviewers (launchpad-reviewers)

For more details, see:
https://code.launchpad.net/~cjwatson/launchpad/upload-timestamp-cutoff-1975/+merge/273211

Bump future_time_grace to 24 hours and earliest_year to 1975, to match Debian.  The earliest_year change is from https://anonscm.debian.org/cgit/mirror/dak.git/commit/?id=394eaf39d605f9b0e916d25d3d5cd223b0c5246e and justified by https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=710086.  I can't find a specific justification in dak for the future_time_grace change, but I think we should remain consistent with dak so that people don't get surprised by different policies between the two archives.
-- 
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~cjwatson/launchpad/upload-timestamp-cutoff-1975 into lp:launchpad.

=== modified file 'lib/lp/archiveuploader/uploadpolicy.py'
--- lib/lp/archiveuploader/uploadpolicy.py	2015-07-08 16:05:11 +0000
+++ lib/lp/archiveuploader/uploadpolicy.py	2015-10-02 10:55:30 +0000
@@ -88,10 +88,10 @@
         self.unsigned_changes_ok = False
         self.unsigned_dsc_ok = False
         self.create_people = True
-        # future_time_grace is in seconds. 28800 is 8 hours
-        self.future_time_grace = 8 * HOURS
+        # future_time_grace is in seconds
+        self.future_time_grace = 24 * HOURS
         # The earliest year we accept in a deb's file's mtime
-        self.earliest_year = 1984
+        self.earliest_year = 1975
 
     def validateUploadType(self, upload):
         """Check that the type of the given upload is accepted by this policy.