launchpad-reviewers team mailing list archive

[Colin Watson <cjwatson@xxxxxxxxxxxxx>]

Colin Watson has proposed merging lp:~cjwatson/launchpad/activereviews-second-person into lp:launchpad.

Commit message:
Describe merge proposal listings in the second person.

Requested reviews:
  Launchpad code reviewers (launchpad-reviewers)
Related bugs:
  Bug #991945 in Launchpad itself: "Launchpad refers to itself as a person"
  https://bugs.launchpad.net/launchpad/+bug/991945

For more details, see:
https://code.launchpad.net/~cjwatson/launchpad/activereviews-second-person/+merge/273348

Describe merge proposal listings in the second person.  Using "I" is confusing when Launchpad is supplying information to the user, rather than when the user is supplying information to Launchpad.
-- 
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~cjwatson/launchpad/activereviews-second-person into lp:launchpad.

=== modified file 'lib/lp/code/browser/branchmergeproposallisting.py'
--- lib/lp/code/browser/branchmergeproposallisting.py	2015-09-30 08:58:44 +0000
+++ lib/lp/code/browser/branchmergeproposallisting.py	2015-10-04 19:21:13 +0000
@@ -373,11 +373,11 @@
         reviewer = self._getReviewer()
         headings = {
             self.APPROVED: 'Approved reviews ready to land',
-            self.TO_DO: 'Reviews I have to do',
-            self.ARE_DOING: 'Reviews I am doing',
-            self.CAN_DO: 'Requested reviews I can do',
-            self.MINE: 'Reviews I am waiting on',
-            self.OTHER: 'Other reviews I am not actively reviewing',
+            self.TO_DO: 'Reviews you have to do',
+            self.ARE_DOING: 'Reviews you are doing',
+            self.CAN_DO: 'Requested reviews you can do',
+            self.MINE: 'Reviews you are waiting on',
+            self.OTHER: 'Other reviews you are not actively reviewing',
             self.WIP: 'Work in progress'}
         if reviewer is None:
             # If there is no reviewer, then there will be no TO_DO, ARE_DOING,

=== modified file 'lib/lp/code/stories/branches/xx-branchmergeproposal-listings.txt'
--- lib/lp/code/stories/branches/xx-branchmergeproposal-listings.txt	2014-12-08 00:32:30 +0000
+++ lib/lp/code/stories/branches/xx-branchmergeproposal-listings.txt	2015-10-04 19:21:13 +0000
@@ -129,7 +129,7 @@
     >>> browser.open('http://code.launchpad.dev/~a-team')
     >>> browser.getLink('Active reviews').click()
     >>> print_tag_with_id(browser.contents, 'proposals')
-    Requested reviews I can do
+    Requested reviews you can do
     Branch Merge Proposal             Requested By    Lines Activity
     lp://dev/~albert/fooix/review ... Albert ...            None
 
@@ -165,7 +165,7 @@
     >>> browser = setupBrowser(auth='Basic albert@xxxxxxxxxxx:test')
     >>> browser.open(url)
     >>> print_tag_with_id(browser.contents, 'proposals')
-    Other reviews I am not actively reviewing
+    Other reviews you are not actively reviewing
     Branch Merge Proposal             Requested By    Lines Activity
     lp://dev/...                      ...                   None
 
@@ -176,6 +176,6 @@
     >>> logout()
     >>> browser.open(url)
     >>> print_tag_with_id(browser.contents, 'proposals')
-    Other reviews I am not actively reviewing
+    Other reviews you are not actively reviewing
     Branch Merge Proposal             Requested By    Lines Activity
     lp://dev/...                      ...             14    None