launchpad-reviewers team mailing list archive

[Colin Watson <cjwatson@xxxxxxxxxxxxx>]

The proposal to merge lp:~cjwatson/turnip/virtualenv into lp:turnip has been updated.

Description changed to:

Add targets to build a virtualenv and to build a tarball with included pip cache.

This is the first step towards making our deployment system more sensible: it will eventually allow us to have a mojo manifest that builds the entire code asset in an appropriate container, virtualenv and all, run tests the whole thing, and upload it to swift for the charm to deploy.  This will involve less downtime on upgrades and will support the autodeployment scheme currently being trialled by Canonical IS.  As a bonus, since the intended use of this is to run the build step in an environment that matches the deployment target, we can switch to installing pygit2 from pip like everything else; 0.22.1 includes our current set of local patches.

This of course requires some additions to turnip-dependencies (pbr-1.8.1.tar.gz, pip-7.1.2.tar.gz, pygit2-0.22.1.tar.gz, setuptools-18.4.tar.gz), which I'll commit if this is accepted, and I'll also commit a similar change to turnipcake in that case so that the charms can remain consistent.

The turnip charm will need to be updated to use this, and that update will involve quite a bit of refactoring, but this part of it can be landed in advance of that, and as a bonus it makes "make check" much more reliable.

For more details, see:
https://code.launchpad.net/~cjwatson/turnip/virtualenv/+merge/274701
-- 
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~cjwatson/turnip/virtualenv into lp:turnip.