launchpad-reviewers team mailing list archive

[Bayard 'kit' Randel <kit.randel@xxxxxxxxxxxxx>]

Review: Approve

That seems like a reasonably future-proof approach.

Diff comments:

> === modified file 'lib/lp/code/mail/patches.py'
> --- lib/lp/code/mail/patches.py	2015-07-09 05:40:01 +0000
> +++ lib/lp/code/mail/patches.py	2015-10-27 01:49:46 +0000
> @@ -372,7 +373,14 @@
>                      dirty_head = []
>                  else:
>                      yield saved_lines
> +                in_git_patch = False
>                  saved_lines = []
> +            if line.startswith('diff --git'):
> +                in_git_patch = True
> +            dirty_head.append(line)
> +            continue
> +        if in_git_patch and line and line[0].islower():

Would it be worth further clarifying `islower()` in the comment?

> +            # Extended header line in a git diff.
>              dirty_head.append(line)
>              continue
>          if line.startswith('*** '):


-- 
https://code.launchpad.net/~cjwatson/launchpad/git-patch-headers/+merge/275792
Your team Launchpad code reviewers is subscribed to branch lp:launchpad.