← Back to team overview

launchpad-reviewers team mailing list archive

Thread
Date

Re: [Merge] lp:~cjwatson/launchpad/bmp-webhooks-permissions into lp:launchpad

To: Colin Watson <cjwatson@xxxxxxxxxxxxx>
From: Bayard 'kit' Randel <kit.randel@xxxxxxxxxxxxx>
Date: Tue, 27 Oct 2015 22:44:43 -0000
In-reply-to: <20151027145123.3282.19328.launchpad@ackee.canonical.com>
Reply-to: mp+275856@xxxxxxxxxxxxxxxxxx
Sender: bounces@xxxxxxxxxxxxx

Review: Approve code

Looks fine. It might be nice to address some of the slightly asymmetrical function names like create_example_merge and createExampleGitMerge for bzr and git respectively at some point.
-- 
https://code.launchpad.net/~cjwatson/launchpad/bmp-webhooks-permissions/+merge/275856
Your team Launchpad code reviewers is subscribed to branch lp:launchpad.

References

[Merge] lp:~cjwatson/launchpad/bmp-webhooks-permissions into lp:launchpad
From: Colin Watson, 2015-10-27