← Back to team overview

launchpad-reviewers team mailing list archive

Re: [Merge] lp:~cjwatson/turnip/virtualenv into lp:turnip

 

Review: Approve

This is great, and I'll be updating rutabaga to reflect this shortly!

I did wonder however if it would be worth providing a similar warning to `make build-tarball`, when PIP_SOURCE_DIR is not set for the `make` target? The `pip install` will fail without it.
-- 
https://code.launchpad.net/~cjwatson/turnip/virtualenv/+merge/274701
Your team Launchpad code reviewers is subscribed to branch lp:turnip.


References