launchpad-reviewers team mailing list archive

[Colin Watson <cjwatson@xxxxxxxxxxxxx>]

Colin Watson has proposed merging lp:~cjwatson/launchpad/remove-empty-portlet into lp:launchpad.

Commit message:
Remove always-empty portlet from Person:+branches.

Requested reviews:
  Launchpad code reviewers (launchpad-reviewers)
Related bugs:
  Bug #1511559 in Launchpad itself: "I see empty portlets ..."
  https://bugs.launchpad.net/launchpad/+bug/1511559

For more details, see:
https://code.launchpad.net/~cjwatson/launchpad/remove-empty-portlet/+merge/276393

Remove always-empty portlet from Person:+branches.  Its content was removed in r14929.
-- 
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~cjwatson/launchpad/remove-empty-portlet into lp:launchpad.

=== modified file 'lib/lp/code/browser/branchlisting.py'
--- lib/lp/code/browser/branchlisting.py	2015-09-23 17:51:12 +0000
+++ lib/lp/code/browser/branchlisting.py	2015-11-02 14:07:20 +0000
@@ -918,12 +918,6 @@
         return self.context
 
     @property
-    def show_action_menu(self):
-        if self.user is not None:
-            return self.user.inTeam(self.context)
-        return False
-
-    @property
     def show_junk_directions(self):
         return self.user == self.context
 
@@ -976,7 +970,6 @@
     no_sort_by = (
         BranchListingSort.DEFAULT, BranchListingSort.OWNER,
         BranchListingSort.PRODUCT)
-    show_action_menu = False
 
     @property
     def person(self):

=== modified file 'lib/lp/code/templates/person-branches.pt'
--- lib/lp/code/templates/person-branches.pt	2015-06-04 08:50:04 +0000
+++ lib/lp/code/templates/person-branches.pt	2015-11-02 14:07:20 +0000
@@ -10,11 +10,6 @@
 
 <metal:side fill-slot="side">
 
-  <div tal:define="menu context/menu:branches"
-       tal:condition="view/show_action_menu"
-       class="first portlet">
-  </div>
-
   <tal:summary replace="structure context/@@+codesummary"/>
 
 </metal:side>