launchpad-reviewers team mailing list archive

[Colin Watson <cjwatson@xxxxxxxxxxxxx>]

Colin Watson has proposed merging lp:~cjwatson/launchpad/twisted-13.0.0-p1 into lp:launchpad.

Commit message:
Upgrade to Twisted 13.0.0-p1, adding diffie-hellman-group14-sha1 support.

Requested reviews:
  Launchpad code reviewers (launchpad-reviewers)

For more details, see:
https://code.launchpad.net/~cjwatson/launchpad/twisted-13.0.0-p1/+merge/276877

Upgrade to Twisted 13.0.0-p1, adding diffie-hellman-group14-sha1 support.

It's taken me far too long to work through all the various bits of yak-shaving (convert to pip, upgrade to latest testtools) required to do a full upgrade to modern Twisted, so here's a backport.  This is just about enough to support OpenSSH 7.0/7.1, although after this we still want to go further and offer at least one SHA-2 key exchange algorithm.

The backport is in https://code.launchpad.net/~canonical-launchpad-branches/twisted/+git/twisted/+ref/lp-backport, from which I used bin/admin/build-tarballs to construct the tarball, and rather to my surprise this worked sensibly first time and the tarball diff only contains what I expected plus the version number changes.  I've verified that I can use both OpenSSH 6.9 and 7.1 to connect to a local codehosting server with these changes.
-- 
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~cjwatson/launchpad/twisted-13.0.0-p1 into lp:launchpad.

=== modified file 'versions.cfg'
--- versions.cfg	2015-08-03 07:06:45 +0000
+++ versions.cfg	2015-11-06 15:20:26 +0000
@@ -126,7 +126,7 @@
 testresources = 0.2.7
 testtools = 0.9.30
 timeline = 0.0.3
-Twisted = 13.0.0
+Twisted = 13.0.0-p1
 txAMQP = 0.6.2
 txfixtures = 0.1.4
 txlongpoll = 0.2.12