launchpad-reviewers team mailing list archive

[Colin Watson <cjwatson@xxxxxxxxxxxxx>]

Colin Watson has proposed merging lp:~cjwatson/launchpad/self-host-fonts into lp:launchpad.

Commit message:
Self-host the Ubuntu webfonts.

Requested reviews:
  Launchpad code reviewers (launchpad-reviewers)
Related bugs:
  Bug #1521472 in Launchpad itself: "Launchpad using google-hosted fonts, not usable in China"
  https://bugs.launchpad.net/launchpad/+bug/1521472

For more details, see:
https://code.launchpad.net/~cjwatson/launchpad/self-host-fonts/+merge/279095

Self-host the Ubuntu webfonts.  Apparently this makes things easier for users behind the Great Firewall of China, and it seems like a good idea on general principles anyway.
-- 
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~cjwatson/launchpad/self-host-fonts into lp:launchpad.

=== added file 'lib/canonical/launchpad/icing/Ubuntu-Bold.woff'
Binary files lib/canonical/launchpad/icing/Ubuntu-Bold.woff	1970-01-01 00:00:00 +0000 and lib/canonical/launchpad/icing/Ubuntu-Bold.woff	2015-12-01 11:13:13 +0000 differ
=== added file 'lib/canonical/launchpad/icing/Ubuntu-BoldItalic.woff'
Binary files lib/canonical/launchpad/icing/Ubuntu-BoldItalic.woff	1970-01-01 00:00:00 +0000 and lib/canonical/launchpad/icing/Ubuntu-BoldItalic.woff	2015-12-01 11:13:13 +0000 differ
=== added file 'lib/canonical/launchpad/icing/Ubuntu-Italic.woff'
Binary files lib/canonical/launchpad/icing/Ubuntu-Italic.woff	1970-01-01 00:00:00 +0000 and lib/canonical/launchpad/icing/Ubuntu-Italic.woff	2015-12-01 11:13:13 +0000 differ
=== added file 'lib/canonical/launchpad/icing/Ubuntu.woff'
Binary files lib/canonical/launchpad/icing/Ubuntu.woff	1970-01-01 00:00:00 +0000 and lib/canonical/launchpad/icing/Ubuntu.woff	2015-12-01 11:13:13 +0000 differ
=== modified file 'lib/canonical/launchpad/icing/ubuntu-webfonts.css'
--- lib/canonical/launchpad/icing/ubuntu-webfonts.css	2012-02-15 15:25:31 +0000
+++ lib/canonical/launchpad/icing/ubuntu-webfonts.css	2015-12-01 11:13:13 +0000
@@ -1,4 +1,4 @@
-/* Web font defintions for the Ubuntu font.
+/* Web font definitions for the Ubuntu font.
  *
  * Retrieved from https://fonts.googleapis.com/css?family=Ubuntu:400,400italic,700,700italic
  *
@@ -8,23 +8,23 @@
   font-family: 'Ubuntu';
   font-style: italic;
   font-weight: normal;
-  src: local('Ubuntu Italic'), local('Ubuntu-Italic'), url('https://themes.googleusercontent.com/static/fonts/ubuntu/v3/kbP_6ONYVgE-bLa9ZRbvvvesZW2xOQ-xsNqO47m55DA.woff') format('woff');
+  src: local('Ubuntu Italic'), local('Ubuntu-Italic'), url('/+icing/Ubuntu-Italic.woff') format('woff');
 }
 @font-face {
   font-family: 'Ubuntu';
   font-style: normal;
   font-weight: bold;
-  src: local('Ubuntu Bold'), local('Ubuntu-Bold'), url('https://themes.googleusercontent.com/static/fonts/ubuntu/v3/0ihfXUL2emPh0ROJezvraD8E0i7KZn-EPnyo3HZu7kw.woff') format('woff');
+  src: local('Ubuntu Bold'), local('Ubuntu-Bold'), url('/+icing/Ubuntu-Bold.woff') format('woff');
 }
 @font-face {
   font-family: 'Ubuntu';
   font-style: italic;
   font-weight: bold;
-  src: local('Ubuntu Bold Italic'), local('Ubuntu-BoldItalic'), url('https://themes.googleusercontent.com/static/fonts/ubuntu/v3/OMD20Sg9RTs7sUORCEN-7YbN6UDyHWBl620a-IRfuBk.woff') format('woff');
+  src: local('Ubuntu Bold Italic'), local('Ubuntu-BoldItalic'), url('/+icing/Ubuntu-BoldItalic.woff') format('woff');
 }
 @font-face {
   font-family: 'Ubuntu';
   font-style: normal;
   font-weight: normal;
-  src: local('Ubuntu'), url('https://themes.googleusercontent.com/static/fonts/ubuntu/v3/_xyN3apAT_yRRDeqB3sPRg.woff') format('woff');
+  src: local('Ubuntu'), url('/+icing/Ubuntu.woff') format('woff');
 }