launchpad-reviewers team mailing list archive

[Colin Watson <cjwatson@xxxxxxxxxxxxx>]

The proposal to merge lp:~cjwatson/launchpad/limit-debdiff into lp:launchpad has been updated.

Description changed to:

Kill debdiff after ten minutes or 1GiB of output by default, and make sure we clean up after it properly.  Add a configurable blacklist.

Some source packages that contain particularly convoluted symlink farms can confuse debdiff into producing exponentially large output, and we should guard ourselves against this possibility.  Ten minutes seems to be a reasonable threshold, as it's larger than the time taken for 99.9% of all successful PackageDiffJobs in 2015 to complete, but I've made it configurable in case we need to tweak it in future.  I've arranged to set TMPDIR because debdiff creates some of its own temporary files there and may not clean them up properly if it's killed.

For more details, see:
https://code.launchpad.net/~cjwatson/launchpad/limit-debdiff/+merge/278187
-- 
Your team Launchpad code reviewers is subscribed to branch lp:launchpad.