← Back to team overview

launchpad-reviewers team mailing list archive

[Merge] lp:~cjwatson/launchpad/git-pending-writes into lp:launchpad

 

Colin Watson has proposed merging lp:~cjwatson/launchpad/git-pending-writes into lp:launchpad.

Commit message:
Show an "Updating repository..." indication when there are pending writes.

Requested reviews:
  Launchpad code reviewers (launchpad-reviewers)

For more details, see:
https://code.launchpad.net/~cjwatson/launchpad/git-pending-writes/+merge/279636

Show an "Updating repository..." indication when there are pending writes.  This makes it a little easier to guess whether a git-based MP isn't updating its diff because of a stalled GitRefScanJob or because of a stalled UpdatePreviewDiffJob.
-- 
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~cjwatson/launchpad/git-pending-writes into lp:launchpad.
=== modified file 'lib/lp/code/templates/gitrepository-index.pt'
--- lib/lp/code/templates/gitrepository-index.pt	2015-09-18 15:41:08 +0000
+++ lib/lp/code/templates/gitrepository-index.pt	2015-12-04 17:52:14 +0000
@@ -57,6 +57,18 @@
     </div>
   </div>
 
+  <div class="yui-g" tal:condition="context/pending_writes">
+    <div class="portlet">
+      <div id="repository-pending-writes" class="pending-update">
+        <h3>Updating repository...</h3>
+        <p>
+          Launchpad is processing new changes to this repository which will
+          be available shortly. Reload to see the changes.
+        </p>
+      </div>
+    </div>
+  </div>
+
 </div>
 
 </body>


Follow ups