launchpad-reviewers team mailing list archive

[Colin Watson <cjwatson@xxxxxxxxxxxxx>]

Review: Approve



Diff comments:

> 
> === modified file 'lib/lp/services/webapp/publication.py'
> --- lib/lp/services/webapp/publication.py	2015-09-28 17:38:45 +0000
> +++ lib/lp/services/webapp/publication.py	2015-12-07 09:27:08 +0000
> @@ -645,6 +647,10 @@
>              request._wants_retry = True
>              if isinstance(exc_info[1], Retry):
>                  raise
> +            # Abort any in-progress transaction and reset any
> +            # disconnected stores. ZopePublication.handleException would
> +            # do this for us if we weren't bypassing it.
> +            transaction.abort()

Does this also need to run in the case where the incoming exception is already Retry, or is it guaranteed that the transaction will already have been aborted in the latter case?  If it's guaranteed, it would be useful for the comment to say so.

>              raise Retry(exc_info)
>  
>          superclass = zope.app.publication.browser.BrowserPublication


-- 
https://code.launchpad.net/~wgrant/launchpad/no-fdt-oopses/+merge/279741
Your team Launchpad code reviewers is subscribed to branch lp:launchpad.