launchpad-reviewers team mailing list archive

[Colin Watson <cjwatson@xxxxxxxxxxxxx>]

Colin Watson has proposed merging lp:~cjwatson/launchpad/db-bpb-external-dependencies into lp:launchpad/db-devel.

Commit message:
Add BinaryPackageBuild.external_dependencies column.

Requested reviews:
  Stuart Bishop (stub): db
  Launchpad code reviewers (launchpad-reviewers)
Related bugs:
  Bug #671190 in Launchpad itself: "cannot specify specific chroot for a build"
  https://bugs.launchpad.net/launchpad/+bug/671190

For more details, see:
https://code.launchpad.net/~cjwatson/launchpad/db-bpb-external-dependencies/+merge/280599

Add BinaryPackageBuild.external_dependencies column.  This will let suitably-privileged people specify an external bootstrap archive to break build-dependency loops, superseding the current mechanism of embedding the bootstrap archive location in the chroot.
-- 
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~cjwatson/launchpad/db-bpb-external-dependencies into lp:launchpad/db-devel.

=== added file 'database/schema/patch-2209-72-0.sql'
--- database/schema/patch-2209-72-0.sql	1970-01-01 00:00:00 +0000
+++ database/schema/patch-2209-72-0.sql	2015-12-15 14:38:28 +0000
@@ -0,0 +1,10 @@
+-- Copyright 2015 Canonical Ltd.  This software is licensed under the
+-- GNU Affero General Public License version 3 (see the file LICENSE).
+
+SET client_min_messages=ERROR;
+
+ALTER TABLE BinaryPackageBuild ADD COLUMN external_dependencies text;
+
+COMMENT ON COLUMN BinaryPackageBuild.external_dependencies IS 'Newline-separated list of repositories to be used to retrieve any external build dependencies when performing this build, in the format: "deb http[s]://[user:pass@]<host>[/path] series[-pocket] [components]".  This is intended for bootstrapping build-dependency loops.';
+
+INSERT INTO LaunchpadDatabaseRevision VALUES (2209, 72, 0);