launchpad-reviewers team mailing list archive

[Colin Watson <cjwatson@xxxxxxxxxxxxx>]

Colin Watson has proposed merging lp:~cjwatson/launchpad/more-layer-isolation-info into lp:launchpad.

Commit message:
Show objects referenced by uncollectable garbage, to ease debugging.

Requested reviews:
  Colin Watson (cjwatson)

For more details, see:
https://code.launchpad.net/~cjwatson/launchpad/more-layer-isolation-info/+merge/280705

Show objects referenced by uncollectable garbage, to ease debugging.  This might help us figure out more detail about reference cycles.
-- 
Your team Launchpad code reviewers is subscribed to branch lp:launchpad.

=== modified file 'lib/lp/testing/layers.py'
--- lib/lp/testing/layers.py	2015-10-13 14:01:25 +0000
+++ lib/lp/testing/layers.py	2015-12-16 11:58:36 +0000
@@ -470,8 +470,9 @@
             if gc.garbage:
                 BaseLayer.flagTestIsolationFailure(
                         "Test left uncollectable garbage\n"
-                        "%s (referenced from %s)"
-                        % (gc.garbage, gc.get_referrers(*gc.garbage)))
+                        "%s (referenced from %s; referencing %s)"
+                        % (gc.garbage, gc.get_referrers(*gc.garbage),
+                           gc.get_referents(*gc.garbage)))
 
     @classmethod
     @profiled