launchpad-reviewers team mailing list archive

[William Grant <me@xxxxxxxxxxxxxxxxxx>]

On 05/01/16 01:57, Colin Watson wrote:
> Review: Needs Information
> 
> This seems to change do_reject to only send the mail, and not
> actually change the status (PU.notify doesn't do that).  That seems
> odd.  Can you explain what's going on there?

The transaction is about to be aborted, so the only side-effect that can
depend on the status is the email. Since we can't reliably set the
status, I opted to be consistent and rely solely on the override.


-- 
https://code.launchpad.net/~wgrant/launchpad/reject-not-accepted/+merge/281435
Your team Launchpad code reviewers is subscribed to branch lp:launchpad.