launchpad-reviewers team mailing list archive

[William Grant <me@xxxxxxxxxxxxxxxxxx>]

Review: Approve code



Diff comments:

> 
> === modified file 'lib/lp/soyuz/interfaces/binarypackagebuild.py'
> --- lib/lp/soyuz/interfaces/binarypackagebuild.py	2015-05-14 08:50:41 +0000
> +++ lib/lp/soyuz/interfaces/binarypackagebuild.py	2016-01-06 12:39:19 +0000
> @@ -266,6 +266,25 @@
>          """
>  
>  
> +class IBinaryPackageBuildRestricted(Interface):
> +    """Restricted `IBinaryPackageBuild` attributes.
> +
> +    These attributes need launchpad.View to see, and launchpad.Moderate to
> +    change.
> +    """
> +    external_dependencies = exported(
> +        Text(
> +            title=_("External dependencies"), required=False, readonly=False,
> +            description=_(
> +                "Newline-separated list of repositories to be used to "
> +                "retrieve any external build dependencies when performing "
> +                "this build, in the format:\n"
> +                "deb http[s]://[user:pass@]<host>[/path] series[-pocket] "
> +                "[components]\n"
> +                "This is intended for bootstrapping build-dependency loops.")),

One build dependency is hyphenated, the other is not!

> +        as_of="devel")
> +
> +
>  class IBinaryPackageBuildAdmin(Interface):
>      """A Build interface for items requiring launchpad.Admin."""
>  


-- 
https://code.launchpad.net/~cjwatson/launchpad/bpb-external-dependencies/+merge/281744
Your team Launchpad code reviewers is subscribed to branch lp:launchpad.