launchpad-reviewers team mailing list archive

[Colin Watson <cjwatson@xxxxxxxxxxxxx>]

Colin Watson has proposed merging lp:~cjwatson/launchpad/db-build-depends-arch into lp:launchpad/db-devel.

Commit message:
Add SourcePackageRelease.builddependsarch and SourcePackageRelease.build_conflicts_arch columns.

Requested reviews:
  Stuart Bishop (stub): db
  Launchpad code reviewers (launchpad-reviewers): db
Related bugs:
  Bug #1489044 in Launchpad itself: "add Build-Depends-Arch support"
  https://bugs.launchpad.net/launchpad/+bug/1489044

For more details, see:
https://code.launchpad.net/~cjwatson/launchpad/db-build-depends-arch/+merge/282344

Add SourcePackageRelease.builddependsarch and SourcePackageRelease.build_conflicts_arch columns.

These aren't yet in policy, but have been in dpkg for a few years (https://bugs.debian.org/629480) without significant changes, and some packages (e.g. mplayer) have started to use them.  I think they need explicit columns rather than using user_defined_fields because they ought to be displayed in the web UI alongside their siblings.

The spelling is peculiar, but I thought it was more important to stay consistent with the existing columns (builddepends, builddependsindep, build_conflicts, build_conflicts_indep).
-- 
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~cjwatson/launchpad/db-build-depends-arch into lp:launchpad/db-devel.

=== added file 'database/schema/patch-2209-74-0.sql'
--- database/schema/patch-2209-74-0.sql	1970-01-01 00:00:00 +0000
+++ database/schema/patch-2209-74-0.sql	2016-01-12 17:04:22 +0000
@@ -0,0 +1,12 @@
+-- Copyright 2016 Canonical Ltd.  This software is licensed under the
+-- GNU Affero General Public License version 3 (see the file LICENSE).
+
+SET client_min_messages=ERROR;
+
+ALTER TABLE SourcePackageRelease ADD COLUMN builddependsarch text;
+ALTER TABLE SourcePackageRelease ADD COLUMN build_conflicts_arch text;
+
+COMMENT ON COLUMN SourcePackageRelease.builddependsarch IS 'The architecture-dependent build-dependencies for this source package release.';
+COMMENT ON COLUMN SourcePackageRelease.build_conflicts_arch IS 'The list of packages that will conflict with this source while building in architecture-dependent environments, as mentioned in the control file "Build-Conflicts-Arch:" field.';
+
+INSERT INTO LaunchpadDatabaseRevision VALUES (2209, 74, 0);