launchpad-reviewers team mailing list archive

[William Grant <me@xxxxxxxxxxxxxxxxxx>]

Review: Approve code



Diff comments:

> === modified file 'lib/lp/code/model/gitrepository.py'
> --- lib/lp/code/model/gitrepository.py	2016-01-12 04:15:40 +0000
> +++ lib/lp/code/model/gitrepository.py	2016-01-12 04:15:40 +0000
> @@ -1047,6 +1047,11 @@
>              prerequisite_git_repository=self):
>              alteration_operations.append(
>                  ClearPrerequisiteRepository(merge_proposal))
> +        deletion_operations.extend(
> +            DeletionCallable(
> +                recipe, msg("This recipe uses this repository."),
> +                recipe.destroySelf)
> +            for recipe in self.recipes)

Worth killing off DeletionCallable.forSourcePackageRecipe? It doesn't seem too useful.

>          if not getUtility(ISnapSet).findByGitRepository(self).is_empty():
>              alteration_operations.append(DeletionCallable(
>                  None, msg("Some snap packages build from this repository."),


-- 
https://code.launchpad.net/~cjwatson/launchpad/git-recipe-delete/+merge/282256
Your team Launchpad code reviewers is subscribed to branch lp:launchpad.