launchpad-reviewers team mailing list archive

[William Grant <me@xxxxxxxxxxxxxxxxxx>]

Review: Approve code



Diff comments:

> 
> === modified file 'lib/lp/code/browser/sourcepackagerecipe.py'
> --- lib/lp/code/browser/sourcepackagerecipe.py	2016-01-11 21:11:27 +0000
> +++ lib/lp/code/browser/sourcepackagerecipe.py	2016-01-12 12:32:25 +0000
> @@ -822,8 +830,8 @@
>      """View for editing Source Package Recipes."""
>  
>      def getBranch(self):
> -        """The branch on which the recipe is built."""
> -        return self.context.base_branch
> +        """The branch or repository which the recipe is built."""

Dropped preposition.

> +        return self.context.base
>  
>      @property
>      def title(self):


-- 
https://code.launchpad.net/~cjwatson/launchpad/git-recipe-browser-existing/+merge/282297
Your team Launchpad code reviewers is subscribed to branch lp:launchpad.