launchpad-reviewers team mailing list archive

[Celso Providelo <celso.providelo@xxxxxxxxxxxxx>]

Review: Approve

Thanks, Colin.

Regarding the DB security changes, do we need to deploy them specially or are they applied for every devel revision on-the-fly ?

The new webhook payload looks complete (action, snap_url, snap_build_url, status) and useful for API operations.

Obviously I'm missing tons of important details, but the drive-by refactoring make sense and testing looks sufficient.

[]
-- 
https://code.launchpad.net/~cjwatson/launchpad/snap-webhooks/+merge/283193
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~cjwatson/launchpad/snap-webhooks into lp:launchpad.