← Back to team overview

launchpad-reviewers team mailing list archive

Re: [Merge] lp:~rbanffy/launchpad/highlight_listing_tr into lp:launchpad

 

Review: Resubmit

Used a CSS selector identical to launchpad_tweaks. If affects pages in the "Code" section.

Diff comments:

> === modified file 'lib/canonical/launchpad/icing/css/base.css'
> --- lib/canonical/launchpad/icing/css/base.css	2015-03-24 11:30:04 +0000
> +++ lib/canonical/launchpad/icing/css/base.css	2016-03-18 20:02:02 +0000
> @@ -402,6 +402,10 @@
>      border: none;
>      }
>  
> +table.listing tbody tr:hover {

This is the selector used with the launchpad_tweaks browser extension, but here it uses #eee instead of lightgrey.

> +    background: #eee;
> +    }
> +
>  table.listing tfoot td {
>      border: 1px solid #d2d2d2;
>      }


-- 
https://code.launchpad.net/~rbanffy/launchpad/highlight_listing_tr/+merge/258766
Your team Launchpad code reviewers is subscribed to branch lp:launchpad.


References