launchpad-reviewers team mailing list archive

[Colin Watson <cjwatson@xxxxxxxxxxxxx>]

Colin Watson has proposed merging lp:~cjwatson/launchpad/dspr-show-sha256 into lp:launchpad.

Commit message:
Show SHA-256 checksums rather than MD5 on DistributionSourcePackageRelease:+files.

Requested reviews:
  Launchpad code reviewers (launchpad-reviewers)
Related bugs:
  Bug #1562632 in Launchpad itself: "package version pages shows MD5 checksum instead of something better"
  https://bugs.launchpad.net/launchpad/+bug/1562632

For more details, see:
https://code.launchpad.net/~cjwatson/launchpad/dspr-show-sha256/+merge/290427

Show SHA-256 checksums rather than MD5 on DistributionSourcePackageRelease:+files.
-- 
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~cjwatson/launchpad/dspr-show-sha256 into lp:launchpad.

=== modified file 'lib/lp/soyuz/stories/soyuz/xx-distributionsourcepackagerelease-pages.txt'
--- lib/lp/soyuz/stories/soyuz/xx-distributionsourcepackagerelease-pages.txt	2015-11-24 01:44:28 +0000
+++ lib/lp/soyuz/stories/soyuz/xx-distributionsourcepackagerelease-pages.txt	2016-03-30 10:20:05 +0000
@@ -195,8 +195,9 @@
     >>> print extract_text(
     ...     find_portlet(anon_browser.contents, 'Downloads'))
     Downloads
-    File                  Size      MD5 Checksum
-    testing-dspr_1.0.dsc  28 bytes  5913c3ad52c14a62e6ae7eef51f9ef42
+    File                  Size      SHA-256 Checksum
+    testing-dspr_1.0.dsc  28 bytes
+    ac512102db9724bee18f26945efeeb82fdab89819e64e120fbfda755ca50c2c6
     View changes file
 
     >>> print anon_browser.getLink('testing-dspr_1.0.dsc').url
@@ -218,8 +219,9 @@
     >>> print extract_text(
     ...     find_portlet(anon_browser.contents, 'Downloads'))
     Downloads
-    File                  Size      MD5 Checksum
-    testing-dspr_1.0.dsc  28 bytes  5913c3ad52c14a62e6ae7eef51f9ef42
+    File                  Size      SHA-256 Checksum
+    testing-dspr_1.0.dsc  28 bytes
+    ac512102db9724bee18f26945efeeb82fdab89819e64e120fbfda755ca50c2c6
     Available diffs
     diff from 0.9 to 1.0 (7 bytes)
     View changes file

=== modified file 'lib/lp/soyuz/stories/soyuz/xx-distroseries-sources.txt'
--- lib/lp/soyuz/stories/soyuz/xx-distroseries-sources.txt	2016-02-05 15:16:29 +0000
+++ lib/lp/soyuz/stories/soyuz/xx-distroseries-sources.txt	2016-03-30 10:20:05 +0000
@@ -86,7 +86,7 @@
   >>> print extract_text(find_portlet(
   ...     content, 'Download files from current release (0.9)'))
   Download files from current release (0.9)
-  File Size MD5 Checksum
+  File Size SHA-256 Checksum
   firefox_0.9.2.orig.tar.gz 9.5 MiB ...
 
   >>> print browser.getLink("firefox_0.9.2.orig.tar.gz").url
@@ -281,7 +281,7 @@
 
   >>> print extract_text(find_portlet(browser.contents, 'Downloads'))
   Downloads
-  File Size MD5 Checksum
+  File Size SHA-256 Checksum
   firefox_0.9.2.orig.tar.gz 9.5 MiB ...
 
   >>> print browser.getLink("firefox_0.9.2.orig.tar.gz").url
@@ -347,7 +347,7 @@
     >>> print extract_text(find_portlet(
     ...     browser.contents, 'Download files from current release (1.0-1)'))
     Download files from current release (1.0-1)
-    File Size MD5 Checksum
+    File Size SHA-256 Checksum
     commercialpackage_1.0.orig.tar.gz 179 bytes ...
     commercialpackage_1.0-1.diff.gz 610 bytes ...
     commercialpackage_1.0-1.dsc 567 bytes ...
@@ -427,7 +427,7 @@
 
     >>> print extract_text(find_portlet(browser.contents, 'Downloads'))
     Downloads
-    File Size MD5 Checksum
+    File Size SHA-256 Checksum
     commercialpackage_1.0.orig.tar.gz 179 bytes ...
     commercialpackage_1.0-1.diff.gz 610 bytes ...
     commercialpackage_1.0-1.dsc 567 bytes ...

=== modified file 'lib/lp/soyuz/templates/distributionsourcepackagerelease-files.pt'
--- lib/lp/soyuz/templates/distributionsourcepackagerelease-files.pt	2014-11-09 00:48:47 +0000
+++ lib/lp/soyuz/templates/distributionsourcepackagerelease-files.pt	2016-03-30 10:20:05 +0000
@@ -8,7 +8,7 @@
     <tr>
     <th>File</th>
     <th>Size</th>
-    <th>MD5 Checksum</th>
+    <th>SHA-256 Checksum</th>
     </tr>
   </thead>
   <tbody>
@@ -20,7 +20,7 @@
             tal:content="file/filename">foo_1.0.dsc</a>
         </td>
         <td tal:content="file/content/filesize/fmt:bytes">10 bytes</td>
-        <td tal:content="file/content/md5">DEADBEEF</td>
+        <td tal:content="file/content/sha256">DEADBEEF</td>
       </tal:file_available>
       <tal:file_unavailable condition="file/deleted">
         <td span="3">