launchpad-reviewers team mailing list archive

[William Grant <me@xxxxxxxxxxxxxxxxxx>]

Review: Approve code



Diff comments:

> 
> === modified file 'lib/lp/soyuz/adapters/archivedependencies.py'
> --- lib/lp/soyuz/adapters/archivedependencies.py	2016-04-02 01:03:27 +0000
> +++ lib/lp/soyuz/adapters/archivedependencies.py	2016-04-04 16:48:40 +0000
> @@ -64,6 +64,14 @@
>      'partner': ['partner'],
>      }
>  
> +# If strict_supported_component_dependencies is disabled, treat the
> +# left-hand components like the right-hand components for the purposes of
> +# finding component dependencies.
> +lax_component_map = {
> +    'main': 'universe',
> +    'restricted': 'multiverse',
> +    }

I would not be able to resist the temptation to replace component_dependencies, lax_component_map and strict_supported_component_dependencies with a list field on ComponentSelection, limiting, I think, the semi-hardcoded silliness to build score calculation.

> +
>  pocket_dependencies = {
>      PackagePublishingPocket.RELEASE: (
>          PackagePublishingPocket.RELEASE,


-- 
https://code.launchpad.net/~cjwatson/launchpad/weaker-ogre-model/+merge/290543
Your team Launchpad code reviewers is subscribed to branch lp:launchpad.