launchpad-reviewers team mailing list archive

[Colin Watson <cjwatson@xxxxxxxxxxxxx>]

Review: Approve



Diff comments:

> === modified file 'database/sampledata/current-dev.sql'
> --- database/sampledata/current-dev.sql	2016-02-24 06:08:16 +0000
> +++ database/sampledata/current-dev.sql	2016-04-12 11:08:15 +0000
> @@ -85,6 +85,7 @@
>  INSERT INTO account (id, date_created, creation_rationale, status, date_status_set, displayname, status_comment) VALUES (2436241, '2008-11-04 12:59:26.965843', 8, 20, '2008-11-04 13:09:43.807125', 'PPA key guard', NULL);
>  INSERT INTO account (id, date_created, creation_rationale, status, date_status_set, displayname, status_comment) VALUES (2436242, '2009-03-17 07:26:14.024613', 1, 20, '2009-03-17 07:26:14.024613', 'Ubuntu-branches-owner', 'Activated when the preferred email was set.');
>  INSERT INTO account (id, date_created, creation_rationale, status, date_status_set, displayname, status_comment) VALUES (2436243, '2009-08-04 10:50:39.383407', 1, 20, '2009-08-04 10:50:39.383407', 'Techboard Owner', 'Activated when the preferred email was set.');
> +INSERT INTO account (id, date_created, creation_rationale, status, date_status_set, displayname, status_comment) VALUES (2436244, '2016-03-11 08:23:55.060903', 1, 20, '2016-03-11 08:23:55.060903', 'Ubuntu-sso', NULL);

Maybe make the displayname a little more informative.

>  
>  
>  ALTER TABLE account ENABLE TRIGGER ALL;


-- 
https://code.launchpad.net/~wgrant/launchpad/ubuntu-sso-celeb/+merge/291614
Your team Launchpad code reviewers is subscribed to branch lp:launchpad.