launchpad-reviewers team mailing list archive

[Colin Watson <cjwatson@xxxxxxxxxxxxx>]

Colin Watson has proposed merging lp:~cjwatson/launchpad/configure-code-git-markup into lp:launchpad.

Commit message:
Add missing table around git_repository_location widget row on Product:+configure-code, so that errors are highlighted properly.

Requested reviews:
  Launchpad code reviewers (launchpad-reviewers)
Related bugs:
  Bug #1552878 in Launchpad itself: "+configure-code view does not highlight error message"
  https://bugs.launchpad.net/launchpad/+bug/1552878

For more details, see:
https://code.launchpad.net/~cjwatson/launchpad/configure-code-git-markup/+merge/293190

Add missing table around git_repository_location widget row on Product:+configure-code, so that errors are highlighted properly.
-- 
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~cjwatson/launchpad/configure-code-git-markup into lp:launchpad.

=== modified file 'lib/lp/code/templates/configure-code.pt'
--- lib/lp/code/templates/configure-code.pt	2016-04-07 13:01:08 +0000
+++ lib/lp/code/templates/configure-code.pt	2016-04-28 02:13:39 +0000
@@ -141,9 +141,11 @@
 
                   <h3>Link an existing repository</h3>
                   <p>Link to an existing Git repository already on Launchpad</p>
-                  <tal:widget define="widget nocall:view/widgets/git_repository_location">
-                    <metal:block use-macro="context/@@launchpad_form/widget_row" />
-                  </tal:widget>
+                  <table>
+                    <tal:widget define="widget nocall:view/widgets/git_repository_location">
+                      <metal:block use-macro="context/@@launchpad_form/widget_row" />
+                    </tal:widget>
+                  </table>
                 </div>
               </div>
             </div>