← Back to team overview

launchpad-reviewers team mailing list archive

Thread
Date

Re: [Merge] lp:~maxiberta/launchpad/git-get-blob into lp:launchpad

To: mp+293337@xxxxxxxxxxxxxxxxxx
From: Maximiliano Bertacchini <maximiliano.bertacchini@xxxxxxxxxxxxx>
Date: Fri, 29 Apr 2016 22:12:34 -0000
In-reply-to: <20160429050724.19433.6060.launchpad@ackee.canonical.com>
Reply-to: mp+293337@xxxxxxxxxxxxxxxxxx
Sender: bounces@xxxxxxxxxxxxx

Addressed all comments. GitHostingClient now uses `requests.Request`'s `params` to automatically quote query parameters; and select path components are now escaped with `urllib.quote()`. Added unit test accordingly.
-- 
https://code.launchpad.net/~maxiberta/launchpad/git-get-blob/+merge/293337
Your team Launchpad code reviewers is subscribed to branch lp:launchpad.

References

[Merge] lp:~maxiberta/launchpad/git-get-blob into lp:launchpad
From: Maximiliano Bertacchini, 2016-04-29