launchpad-reviewers team mailing list archive

[William Grant <me@xxxxxxxxxxxxxxxxxx>]

Review: Approve code



Diff comments:

> 
> === modified file 'lib/lp/code/templates/git-macros.pt'
> --- lib/lp/code/templates/git-macros.pt	2016-05-13 14:30:57 +0000
> +++ lib/lp/code/templates/git-macros.pt	2016-05-13 14:30:57 +0000
> @@ -152,6 +153,14 @@
>        replace="structure commit_message/fmt:obfuscate-email/fmt:text-to-html" />
>    </dd>
>  
> +  <div tal:define="merge_proposal python:commit_info['merge_proposal']"
> +       tal:condition="merge_proposal">
> +    <dd class="subordinate commit-comment">
> +      <a tal:attributes="href merge_proposal/fmt:url">Merged</a> branch
> +      <a tal:replace="structure merge_proposal/merge_source/fmt:link">source branch</a>

This isn't always linkable, since the ref may have been deleted.

> +    </dd>
> +  </div>
> +
>  </metal:commit-text>
>  
>  <metal:no-commit-message define-macro="no-commit-message">


-- 
https://code.launchpad.net/~cjwatson/launchpad/git-commits-link-mps/+merge/294653
Your team Launchpad code reviewers is subscribed to branch lp:launchpad.