← Back to team overview

launchpad-reviewers team mailing list archive

Thread
Date

Re: [Merge] lp:~free.ekanayaka/txlongpoll/fast-rabbit-reset into lp:txlongpoll

To: mp+278287@xxxxxxxxxxxxxxxxxx
From: Free Ekanayaka <free.ekanayaka@xxxxxxxxxxxxx>
Date: Tue, 24 May 2016 10:33:26 -0000
In-reply-to: <20160524101446.18136.9270.codereview@soybean.canonical.com>
Reply-to: mp+278287@xxxxxxxxxxxxxxxxxx
Sender: bounces@xxxxxxxxxxxxx

> The whole custom runner is not needed, is it? Why is it there. Surely a
> load_tests hook is much cleaner.

Nice, didn't know about it. Fixed as suggested.
-- 
https://code.launchpad.net/~free.ekanayaka/txlongpoll/fast-rabbit-reset/+merge/278287
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~free.ekanayaka/txlongpoll/fast-rabbit-reset into lp:txlongpoll.

References

Re: [Merge] lp:~free.ekanayaka/txlongpoll/fast-rabbit-reset into lp:txlongpoll
From: Robert Collins, 2016-05-24