launchpad-reviewers team mailing list archive

[William Grant <me@xxxxxxxxxxxxxxxxxx>]

Review: Needs Fixing code

I don't think we can safely move the full cache update into a hot interactive path; the binary queries are quite slow, in part due to test rebuilds.

This looks like a perfect opportunity to exploit update-pkgcache's "let's just regenerate the whole thing" approach. newSourcePublication should ensure a row exists for the source name, leaving new sources unsearchable by binary details until the next cache update. It's even more benign than it sounds, since binaries for a new source won't exist at newSourcePublication time anyway.
-- 
https://code.launchpad.net/~cjwatson/launchpad/update-pkgcache-on-publish/+merge/295929
Your team Launchpad code reviewers is subscribed to branch lp:launchpad.